Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcmicro_io.zip cell and nucleus bitmasks are the same #52

Closed
keller-mark opened this issue Sep 20, 2023 · 4 comments · Fixed by scverse/spatialdata-io#28
Closed

mcmicro_io.zip cell and nucleus bitmasks are the same #52

keller-mark opened this issue Sep 20, 2023 · 4 comments · Fixed by scverse/spatialdata-io#28

Comments

@keller-mark
Copy link

Is this expected?

Screenshot 2023-09-20 at 10 52 38 AM
Screenshot 2023-09-20 at 10 52 50 AM
Screenshot 2023-09-20 at 10 52 56 AM

@keller-mark
Copy link
Author

It also could be improved by having more meaningful labels in channels_metadata - it seems like there are good names in table.var.index

"channels_metadata": {
        "channels": [
            {
                "label": 0
            },
            {
                "label": 1
            },
            {
                "label": 2
            },
            {
                "label": 3
            },
            {
                "label": 4
            },
            {
                "label": 5
            },
            {
                "label": 6
            },
            {
                "label": 7
            },
            {
                "label": 8
            },
            {
                "label": 9
            },
            {
                "label": 10
            },
            {
                "label": 11
            }
        ]
    },

@LucaMarconato
Copy link
Member

@keller-mark could you please try using this PR, which improved the mcmicro reader: scverse/spatialdata-io#28?

@LucaMarconato
Copy link
Member

Actually, this doesn't fix the problem, I will check for a solution.

@LucaMarconato
Copy link
Member

Getting back to this. The incoming PR (I'll try to merge it today) scverse/spatialdata-io#28 assigns the channel names to the image (and generalizes the reader to support more complex outputs of the mcmicro pipeline).

Regarding the cell vs nuclei, I examined the code and the files, and realized that problem is already present in the data, and therefore is not due to our reader. I reported this in the mcmicro repository labsyspharm/mcmicro#531.

@LucaMarconato LucaMarconato linked a pull request Jan 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants