Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dims for backwards compatibility of image loading #508

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

MxMstrmn
Copy link
Collaborator

@MxMstrmn MxMstrmn commented Apr 6, 2022

IMPORTANT: Please search among the Pull requests before creating one.

Description

Include check to be able to load ImageContainer that were generated from another version of squidpy.

How has this been tested?

Fixes loading of ImageContainer for me, see #507.

Closes

#507

Include check to be able to load ImageContainer that were generated from another vesion of squidpy.

Close #507.
@MxMstrmn MxMstrmn requested review from giovp and michalk8 April 6, 2022 21:31
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #508 (973c04d) into master (e561bc4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #508   +/-   ##
=======================================
  Coverage   77.97%   77.97%           
=======================================
  Files          31       31           
  Lines        4350     4350           
  Branches      798      798           
=======================================
  Hits         3392     3392           
  Misses        735      735           
  Partials      223      223           
Impacted Files Coverage Δ
squidpy/im/_container.py 86.78% <100.00%> (ø)

Copy link
Collaborator

@michalk8 michalk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @MxMstrmn , this was overlooked (similar approach was used in here).

@michalk8 michalk8 added the bugfix PR fixes a bug label Apr 6, 2022
@michalk8 michalk8 merged commit 61e8b3b into master Apr 6, 2022
michalk8 added a commit that referenced this pull request Apr 6, 2022
michalk8 added a commit that referenced this pull request Apr 6, 2022
@michalk8 michalk8 deleted the fix/infer_dims branch April 10, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants