Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove column assignment to improve compatibility with new cell metad… #648

Merged
merged 1 commit into from Mar 7, 2023

Conversation

cornhundred
Copy link
Contributor

Description

This pull request addresses this issue #647 where the read function is unable to support updated versions of cell metadata (see https://vizgen.github.io/vizgen-postprocessing/output_data_formats/entity_metadata_format.html). We remove the assignment of column names to allow for modifications to cell metadata.

How has this been tested?

I have tested that this modification allows squidpy to load the previous and current versions of cell metadata.

adata = sq.read.vizgen(
...   'Mouse_Brain_Showcase/', 
...   counts_file = 'cell_by_gene.csv', 
...   meta_file = 'cell_metadata.csv')

Closes

closes #647

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #648 (c39e724) into main (4819abc) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
+ Coverage   78.56%   78.58%   +0.01%     
==========================================
  Files          31       31              
  Lines        4469     4468       -1     
  Branches      858      858              
==========================================
  Hits         3511     3511              
+ Misses        705      704       -1     
  Partials      253      253              
Impacted Files Coverage Δ
squidpy/read/_read.py 38.09% <ø> (+0.44%) ⬆️

@michalk8 michalk8 added the bugfix PR fixes a bug label Mar 7, 2023
@michalk8 michalk8 self-requested a review March 7, 2023 14:06
Copy link
Collaborator

@michalk8 michalk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@cornhundred
Copy link
Contributor Author

Thanks @michalk8!

@cornhundred cornhundred deleted the vizgen_cell_metadata branch March 7, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read Vizgen Cell Metadata not compatible with updated formats
3 participants