Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable MaxRequestsPerConn cluster param #113

Merged
merged 1 commit into from
Feb 16, 2023

Commits on Feb 16, 2023

  1. Add configurable MaxRequestsPerConn cluster param

    Before this change, a connection had a hardcoded maximum number of
    streams. Since this value was so large (32768 for CQL v3+) this
    essentially meant an unbound concurrency.
    
    This commit allows a user to configure this parameter by a newly
    added MaxRequestsPerConn option.
    
    The "MaxRequestsPerConn" naming was chosen to be very general
    deliberately to allow us to safely introduce a more advanced behavior in
    the future: where the concurrency limiting happens not at a IDGenerator
    level and an additional client-side queue is introduced for requests
    to wait to be sent to Scylla (in addition to inflight requests).
    
    This commit deliberately does not change the defaults as to be
    non-pessimizing for the users.
    
    Fixes scylladb#112
    avelanarius committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    cc4c65b View commit details
    Browse the repository at this point in the history