Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutex token aware sharding initializer #95

Closed
wants to merge 1 commit into from

Conversation

steve-gray
Copy link

  • Prevents data race when/if a schema update happens during an initialization.

I believe this addresses #94.

- Prevents data race when/if a schema update happens during an initialization.
@steve-gray
Copy link
Author

@mmatczuk - One for you, It seems pretty safe to call the mutex here, and it stops the issues fine in my CI runs locally. I've got a lot of tests where I set up keyspaces, do a bunch of operations then blow away the keyspace so each test is idempotent. I doubt this will happen to anyone in the wild, and will have been an issue for a long while I suspect. If I re-run CI enough, tests will pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants