Fix cqlengine tests #210
Merged
Fix cqlengine tests #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use pytest to run our tests, but cqlenginge inegration tests were using nose's setup_package / teardown_package functions which are not supported by pytest. This causes most of those tests to fail. This commit changes this to pytest's autouse fixture, increasing amount of passing tests in integration/cqlengine from 185 to 516.
Some integration tests use indexes on non-frozen collections. Support for those was merged to Scylla, but will be available from Scylla 5.2. Mark the tests that require such indexes, so they are not run with Scylla < 5.2.
Scylla returns not only `[applied]` column, but also the previous value of a row. Tests didn't allow it - this commit fixes the problem.
One test requires custom indexes, which are not supported by Scylla. Mark the test as such,so it's not executed with Scylla.
When creating a table with compaction strategy class like `org.apache.cassandra.db.compaction.LeveledCompactionStrategy` it will be siltently renamed by Scylla to `LeveledCompactionStrategy`. This caused some tests to fail, so this commit accomodates this behaviour.
Some tests check that specific amout of warnings is emited, but warnings module deduplicates warnings by default, causing those tests to fail. This commits disables this filtering to fix the tests.
Batch statements can be executed in (at least) 2 ways. 1. Using BatchStatement 2. Using SimpleStatement with string like `BEGIN BATCH ...` The second way was not handled by `was_applied` property of ResultSet`. This caused some tests to fail. This commit fixes the problem.
All the test should now pass so we can enable them.
|
Just for some context, we didn't run those tests mostly cause we didn't touch/changed anything in the cqlengine code. So no changes, no much reason to run those. regardless there were some changes requested around cqlengine (some from @k0machi, as part of the work done on Argus) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us a step closed to fixing tests (see #207 for reference).
This PR fixes (or skips) all the tests in tests/integration/cqlengine and enables them in CI.
Changes are divided into commits - see commit messages and changes to learn about individual fixes.