github/workflows/nix: do not set env var with another env var #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change addresses a regression introduced by 9249491. in 9249491, we tried to set `$SCYLLA_VERSION` with `env.RELOC_VERSION`, but github action does not allow this. because the env variables in github's workflow YAML are expanded when the YAML file is parsed. so `SCYLLA_VERSION` is never expanded with the value of `RELOC_VERSION`. so, in this change, to avoid the repeatings, we use environmental file to store `SCYLLA_VERSION`, so that it can be picked by the steps that consume this env var. see also https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change addresses a regression introduced by 9249491.
in 9249491, we tried to set
$SCYLLA_VERSIONwithenv.RELOC_VERSION, but github action does not allow this. because the env variables in github's workflow YAML are expanded when the YAML file is parsed. soSCYLLA_VERSIONis never expanded with the value ofRELOC_VERSION.so, in this change, to avoid the repeatings, we use environmental file to store
SCYLLA_VERSION, so that it can be picked by the steps that consume this env var.see also https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files