-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ruby): adding ruby project #20
Conversation
@annastuchlik @tzach I think that's everything good to go. Maybe a last review just in case :p also @cherryramatisdev thanks for the awesome contribution! |
Hey @cherryramatisdev I think that we're good to go on this PR. Could you please validate if there's anything missing and rebase your branch? Thanks! |
3dacbed
to
8db4584
Compare
I was reviewed a couple times and it's all good with the code propose! I did the rebase as you mentioned @DanielHe4rt Thanks again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
If any improvement is necessary for this PR to be merged, please let me know!