Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ruby): adding ruby project #20

Merged
merged 22 commits into from
Sep 4, 2023

Conversation

cherryramatisdev
Copy link
Contributor

If any improvement is necessary for this PR to be merged, please let me know!

Thanks to @DanielHe4rt for inspiring me to contribute on this repository.

@DanielHe4rt
Copy link
Collaborator

@annastuchlik @tzach I think that's everything good to go.

Maybe a last review just in case :p

also @cherryramatisdev thanks for the awesome contribution!

@DanielHe4rt
Copy link
Collaborator

Hey @cherryramatisdev I think that we're good to go on this PR. Could you please validate if there's anything missing and rebase your branch?

Thanks!

@cherryramatisdev
Copy link
Contributor Author

I was reviewed a couple times and it's all good with the code propose! I did the rebase as you mentioned @DanielHe4rt

Thanks again

Copy link
Collaborator

@DanielHe4rt DanielHe4rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DanielHe4rt DanielHe4rt merged commit dc3d774 into scylladb:main Sep 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants