scrub: support scrub_mode #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denesb
reviewed
Aug 18, 2021
| public int scrub(boolean disableSnapshot, boolean skipCorrupted, boolean checkData, boolean reinsertOverflowedTTL, | ||
| int jobs, String keyspaceName, String... columnFamilies) | ||
| throws IOException, ExecutionException, InterruptedException; | ||
|
|
||
| public int scrub(boolean disableSnapshot, boolean skipCorrupted, String scrubMode, boolean checkData, boolean reinsertOverflowedTTL, | ||
| int jobs, String keyspaceName, String... columnFamilies) | ||
| throws IOException, ExecutionException, InterruptedException; |
There was a problem hiding this comment.
I think there should be a variant with skipCorrupted and one with scrubMode, doesn't really make sense to set both, as they conflict (and I don't recall how the conflict is resolved in the API).
There was a problem hiding this comment.
Hmm, that makes sense. Our documentation says that scrubMode trumps skipCorrupted.
https://github.com/scylladb/scylla/blob/f98cb965067b8a8f640840387dcbf043a0885d8c/api/api-doc/storage_service.json#L798
Support new scrubMode option and deprecate skipCorrupted that's equivalent to scrubMode="SKIP". Signed-off-by: Benny Halevy <bhalevy@scylladb.com>
bhalevy
force-pushed
the
api-scrub-mode
branch
from
bbbdd85
to
fc24c74
Compare
|
In v2:
|
denesb
approved these changes
Aug 23, 2021
|
@scylladb/scylla-jmx-maint please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the scrub_mode option for the scylla api.
Signed-off-by: Benny Halevy bhalevy@scylladb.com