Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus metrics relabel is not up to date #1672

Open
amnonh opened this issue Jan 4, 2024 · 6 comments
Open

Prometheus metrics relabel is not up to date #1672

amnonh opened this issue Jan 4, 2024 · 6 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@amnonh
Copy link

amnonh commented Jan 4, 2024

What happened?

Scylla Enterprise versions 2023.1.x and higher do not show shard-level metrics in the dashboards.

What did you expect to happen?

NA

How can we reproduce it (as minimally and precisely as possible)?

NA

Scylla Operator version

NA

Kubernetes platform name and version

```console $ kubectl version # paste output here ```

Kubernetes platform info:

Please attach the must-gather archive.

NA

Anything else we need to know?

Look at the metrics relabel config between this line:
https://github.com/scylladb/scylla-monitoring/blob/1ab337a505e4f57ec15001480d0898c6d18c8a76/prometheus/prometheus.yml.template#L75
And this line:
https://github.com/scylladb/scylla-monitoring/blob/1ab337a505e4f57ec15001480d0898c6d18c8a76/prometheus/prometheus.yml.template#L126
@amnonh amnonh added the kind/bug Categorizes issue or PR as related to a bug. label Jan 4, 2024
@scylla-operator-bot scylla-operator-bot bot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 4, 2024
@mykaul
Copy link
Contributor

mykaul commented Jan 4, 2024

@amnonh - do we need to update the monitoring in the operator? 4.6 is out, it's a good time to do it?

@tnozicka tnozicka added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 4, 2024
@scylla-operator-bot scylla-operator-bot bot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 4, 2024
@amnonh amnonh removed their assignment Jan 4, 2024
@amnonh
Copy link
Author

amnonh commented Jan 4, 2024

I'm removing myself as assigned, assign me if you need more information or if you want to me to do anything

@tnozicka
Copy link
Member

tnozicka commented Jan 4, 2024

@amnonh @mykaul's directions were that monitoring team should be updating the dashboard definitions here, that's the reason this was assigned to you.

@amnonh
Copy link
Author

amnonh commented Jan 4, 2024

I've opened the issue around the Prometheus relabel config, which is broken for 2023.1 and higher.

amnonh added a commit to amnonh/scylla-operator that referenced this issue Jan 7, 2024
@amnonh
scylladb.servicemonitor.yaml: Support Enterprise 2023
59797a6 
Newer ScyllaDB versions (2023.1, 5.4) moves the latency calculation from
the Prometheus Server to ScyllaDB itself.

The promethues server needs to rename those newly-calculated metrics to
be alligned with the ones calculated by the recording rules.

This patch adds the missing metrics_relabel config from Sylla-monitoring.

Fixes scylladb#1672

Signed-off-by: Amnon Heiman <amnon@scylladb.com>
@amnonh amnonh mentioned this issue Jan 7, 2024
Closed
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out

/lifecycle stale

@scylla-operator-bot scylla-operator-bot bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2024
@tnozicka
Copy link
Member

tnozicka commented Jul 3, 2024

/remove-lifecycle stale
/triage accepted

@scylla-operator-bot scylla-operator-bot bot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scylladb.servicemonitor.yaml: Support Enterprise 2023 amnonh/scylla-operator
3 participants
@amnonh @mykaul @tnozicka