Fix assertion in e2e testing ingress connectivity

[zimnx]

Eventually block without .Should(o.Succeed()) silently passes after first failed execution. This adds this missing assertion fixing the test.

[rzetelskik]

Any chance this is related to #1476?

[tnozicka]

good catch, thx

/approve
/lgtm

[scylla-operator-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tnozicka,zimnx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zimnx]

Any chance this is related to #1476?

I don't think so, what I'm fixing in this PR are false positives.

[zimnx]

2x manager flake
/retest

[zimnx]

And another one manager flake
/retest

[zimnx]

come on manager
/retest

[zimnx]

again
/retest

[zimnx]

Manager flake

/override ci/prow/e2e-gke-parallel-clusterip

[scylla-operator-bot]

@zimnx: Overrode contexts on behalf of zimnx: ci/prow/e2e-gke-parallel-clusterip

In response to this:

Manager flake

/override ci/prow/e2e-gke-parallel-clusterip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.