Increase Scylla probes timeout to 30s #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimnx
force-pushed
the
mz/increase-probe-timeout
branch
from
a7dd8dd
to
ce36a23
Compare
tnozicka
reviewed
Nov 22, 2021
zimnx
force-pushed
the
mz/increase-probe-timeout
branch
from
ce36a23
to
057a17e
Compare
done |
tnozicka
previously approved these changes
Nov 22, 2021
| @@ -342,7 +344,9 @@ func StatefulSetForRack(r scyllav1.RackSpec, c *scyllav1.ScyllaCluster, existing | |||
| }, | |||
| }, | |||
| LivenessProbe: &corev1.Probe{ | |||
| TimeoutSeconds: int32(5), | |||
| // TODO: temporarily increase timeout from 5s to 30s to survive node overload | |||
There was a problem hiding this comment.
nit: the TODO should say what needs to be done in the future. Like TODO: Lower the timeout when we fix probe timeouts. We have temporarily increased the timeout not to kill nodes when under load.
The issue that is reverenced should have a clear action item to remove this TODO and lower the timeout.
zimnx
force-pushed
the
mz/increase-probe-timeout
branch
from
057a17e
to
7937dc1
Compare
tnozicka
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #844