Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/vpc_peering: deprecate peer_cidr_block attribute (schema version 1 + migration) #113

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

rjeczalik
Copy link
Member

This PR deprecates the peer_cidr_block attribute, in favor of more generic peer_cidr_blocks one.

Any existing terraform resources which use the peer_cidr_block attribute need to be updated to use peer_cidr_blocks one, which is usually as simple as changing the following:

resource "scylladbcloud_vpc_peering" "x" {
    ...

    peer_cidr_block = "10.0.0.0/16"

    ...
}

to:

resource "scylladbcloud_vpc_peering" "x" {
    ...

    peer_cidr_blocks = ["10.0.0.0/16"]

    ...
}

Also this resource schema will be version at 1 and any old state file will be migrated automatically.

@rjeczalik
Copy link
Member Author

Example of updated state file:

pic

…sion 1 + migration)

This PR deprecates the peer_cidr_block attribute, in favor of more generic peer_cidr_blocks one.

Any existing terraform resources which use the `peer_cidr_block` attribute need to be updated
to use `peer_cidr_blocks` one, which is usually as simple as changing the following:

    resource "scylladbcloud_vpc_peering" "x" {
        ...

        peer_cidr_block = "10.0.0.0/16"

        ...
    }

to:

    resource "scylladbcloud_vpc_peering" "x" {
        ...

        peer_cidr_blocks = ["10.0.0.0/16"]

        ...
    }

Also this resource schema will be version at 1 and any old state file will be migrated automatically.
@rjeczalik rjeczalik merged commit b35ed02 into main Feb 8, 2024
4 checks passed
@rjeczalik rjeczalik deleted the rj/deprecate-cidr-block branch February 8, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant