Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed Miniproject 1 #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Completed Miniproject 1 #4

wants to merge 5 commits into from

Conversation

jwen2
Copy link

@jwen2 jwen2 commented Sep 24, 2017

Completed miniproject 1 with revisions.

Copy link

@SeunginLyu SeunginLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good overall, but you forgot to push your code for part2!

@@ -2,7 +2,7 @@
"""
YOUR HEADER COMMENT HERE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the upcoming mini projects, please add your name and a short description of the project.

""" Checks for each letter and returns the complement
(might not be the most effiicent way) and returns
'This is not a nucleotide' if any other letters are implented
Returns the complementary nucleotide

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Adding appropriate docstrings is always helpful.

elif nucleotide == 'G':
return 'C'
else:
return 'This is not a nucleotide'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way to hand errors 👍
raise ValueError(nucleotide, " is not a nucleotide")

# index = index + 3
# newstr1.append(dna[index+3:])
# #checks to find
# return newstr1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments when submitting your final code.

@@ -78,28 +128,52 @@ def find_all_ORFs_oneframe(dna):
returns: a list of non-nested ORFs
>>> find_all_ORFs_oneframe("ATGCATGAATGTAGATAGATGTGCCC")
['ATGCATGAATGTAGA', 'ATGTGCCC']
>>> find_all_ORFs_oneframe("TTTATGCCCTAGATAATGTTTTAGATGCCCTAG")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Always add more custom test cases to verify your function.

pass
#print(find_all_ORFs_oneframe("ATGCATGAATGTAGATAGATGTGCCC"))
#print(find_all_ORFs_oneframe('AAAAAAAATAGAAA'))
#print(find_all_ORFs_oneframe('AAAATTTTTTAATTTTTTATTATA'))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, remove comments for the final code

gene_finder.py Outdated
# returns: a list of all amino acid sequences coded by the sequence dna.
# """
# # TODO: implement this
# pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you forgot to push your code for part2. can you push those changes as well?

@jwen2
Copy link
Author

jwen2 commented Oct 2, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants