Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed values and Arithmetic Shift #22

Closed
wants to merge 1 commit into from
Closed

Conversation

sdamghan
Copy link
Owner

Support signed values for arithmetic shift

Odin does not completely support signed values yet. As already the implementation of arithmetic shift operation has been done completely, a solution is proposed to have the signed values shift operation support.

Description

This commit includes a new function, defined in ast_util to resolve the missed hierarchical contents for IDENTIFIERs. Odin creates a new IDENTIFIER ast_node when counters with global or local variable usage. However, critical information like variable signedness was not transferred to the new node. So, the new function addresses this problem when Odin reduces expressions.

Related Issue

Commits verilog-to-routing#1560 and verilog-to-routing#1468
Issue #38

Motivation and Context

How Has This Been Tested?

1. make test (ODIN-II)
2. Basic Regression Tests
3. Strong Regression Test
4. Basic Valgrind Memory Tests (also, Valgrind memory tests for all other regression suits)
5. Sanitized Basic Regression Tests
6. Odin-II Micro Tests

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

* support signed values in arithmetic shift left
@github-actions github-actions bot added the Odin label Jan 14, 2021
@sdamghan sdamghan closed this Jun 8, 2021
@sdamghan sdamghan deleted the signed_asr_support branch November 19, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant