Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odin: add reserved keyword support in Flex and verify standard #1468

Merged
merged 6 commits into from
Aug 6, 2020
Merged

Odin: add reserved keyword support in Flex and verify standard #1468

merged 6 commits into from
Aug 6, 2020

Conversation

jeanlego
Copy link
Contributor

@jeanlego jeanlego commented Aug 6, 2020

Description

This PR:

  • add the ieee_std verification before passing over tokens in flex
  • completes the reserved keyword support,

TODO:

  • add c functions support

Motivation and Context

verilog 2005 support

How Has This Been Tested?

no new test was added since this does not ast support.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@probot-autolabeler probot-autolabeler bot added lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item labels Aug 6, 2020
@jeanlego
Copy link
Contributor Author

jeanlego commented Aug 6, 2020

@emacdo12 and @sdamghan can one of you review?

ODIN_II/SRC/verilog_bison.y Outdated Show resolved Hide resolved
this commit:
- finish the restricted keyword support in flex
- fix the indentation in flex
- sanitize the ieee std based on the input.
merge the REG logic with the INTEGER data type
the only difference is that the integer is 32 bit and signed
Copy link
Contributor

@emacdo12 emacdo12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumps out to me for this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants