Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polydisperse Spheres #1

Open
kartikye opened this issue Mar 17, 2021 · 4 comments
Open

Polydisperse Spheres #1

kartikye opened this issue Mar 17, 2021 · 4 comments

Comments

@kartikye
Copy link

Hi!

Did you by any chance implement support for spheres of different sizes?

@sdatkinson
Copy link
Owner

Hi.

So this version doesn't support polydisperse spheres, but it's certainly possible.

I don't have plans to implement it myself since I don't really work on the sorts of problems this solves anymore, but if you're interested in taking a crack at it the changes would basically involve

  • taking the diameter property in the packing class, moving it to be a property of each sphere (probably want to use radii since IIRC most calculations involve the sum of two radii which just happens to be a diameter for monodisperse).
  • Modify references to it accordingly (probably when making constraints & maintaining the near-neighbor lists)
  • Then provide the radii somehow e.g. as another column after the coordinates or as another file.

@kartikye
Copy link
Author

Got it, Thanks!

Secondly, do you have a licence in mind for the code?

@sdatkinson
Copy link
Owner

Secondly, do you have a licence in mind for the code?

Right, apologies as this was made public quite a while back...Fixed :)

@kartikye
Copy link
Author

kartikye commented Mar 25, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants