Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning Hasseb driver #78

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Cleaning Hasseb driver #78

merged 1 commit into from
Aug 24, 2020

Conversation

dgomes
Copy link
Contributor

@dgomes dgomes commented Aug 11, 2020

Finally got sometime to upgrade my setup with Hasseb controller.

The driver has these orphan imports

Also of note:

  • It requires pyhidapi

From a previous PR from @hasseb :

"To install pyhidapi:
git clone https://github.com/awelkie/pyhidapi.git
cd pyhidapi
sudo python3 setup.py install"

This is important as this library is not available as a pip package... can we replace this by something more standard @hasseb ?

@dgomes
Copy link
Contributor Author

dgomes commented Aug 11, 2020

Propose https://github.com/apmorton/pyhidapi

@hasseb
Copy link
Contributor

hasseb commented Aug 11, 2020

I will try if I get it work with both Windows and Linux, it may also work with Mac which would be nice as well.

@sde1000 sde1000 merged commit bbaa45a into sde1000:master Aug 24, 2020
@dgomes
Copy link
Contributor Author

dgomes commented Aug 28, 2020

@sde1000 could you possibly make a 0.7.1 release to include this fix ?

@kbacia7
Copy link

kbacia7 commented Sep 3, 2020

@hasseb Hello, can you somewhere on wiki add information about update firmware for your devices?
I mean, move somewhere to website this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants