Skip to content
This repository was archived by the owner on Jan 13, 2024. It is now read-only.

Commit 5c3d42c

Browse files
committed
call get_temp_folder in a unit test instead of cleaning a temporary folder
1 parent 29bfbd3 commit 5c3d42c

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

_unittests/ut_helpgen/test_notebooks.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
from src.pyquickhelper.loghelper.flog import fLOG, run_cmd
2525
from src.pyquickhelper.helpgen.sphinx_main import process_notebooks, add_notebook_page
26+
from src.pyquickhelper import get_temp_folder
2627

2728
if sys.version_info[0] == 2:
2829
from codecs import open
@@ -50,12 +51,8 @@ def test_notebook(self):
5051
nb = os.path.join(fold, "example_pyquickhelper.ipynb")
5152
assert os.path.exists(nb)
5253

53-
temp = os.path.join(path, "temp_nb")
54-
if not os.path.exists(temp):
55-
os.mkdir(temp)
56-
for file in os.listdir(temp):
57-
os.remove(os.path.join(temp, file))
58-
54+
temp = get_temp_folder(__file__, "temp_nb")
55+
5956
if sys.platform.startswith("win"):
6057
p1 = r"C:\Program Files\MiKTeX 2.9\miktex\bin\x64"
6158
p2 = r"%USERPROFILE%\AppData\Local\Pandoc"

src/pyquickhelper/helpgen/process_notebooks.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,6 @@ def process_notebooks(notebooks,
167167
if not os.path.exists(build_slide):
168168
os.mkdir(build_slide)
169169

170-
# for some reason, sometimes, the folder is not in write mode
171-
change_file_status(build_slide)
172-
173170
if "WinPython" in sys.executable:
174171
# pip, or any program in Scripts cannot find python.exe
175172
# for the distribution WinPython

src/pyquickhelper/pycode/utils_tests.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
from __future__ import print_function
99

1010
import os
11+
import stat
1112
import sys
1213
import glob
1314
import re
@@ -48,12 +49,20 @@ def get_temp_folder(thisfile, name, clean=True, create=True):
4849
if not os.path.exists(local):
4950
if create:
5051
os.mkdir(local)
52+
mode = os.stat(local).st_mode
53+
nmode = mode | stat.S_IWRITE
54+
if nmode != mode:
55+
os.chmod(local, nmode)
5156
else:
5257
if clean:
5358
remove_folder(local)
5459
time.sleep(0.1)
5560
if create and not os.path.exists(local):
5661
os.mkdir(local)
62+
mode = os.stat(local).st_mode
63+
nmode = mode | stat.S_IWRITE
64+
if nmode != mode:
65+
os.chmod(local, nmode)
5766

5867
return local
5968

0 commit comments

Comments
 (0)