-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Rails 7.0 #42
Allow Rails 7.0 #42
Conversation
- Remove dependabot - Remove travis - Move to SVG versions
0119518
to
11863e2
Compare
@sds ? |
Hello 👋 Is there any reasons why it isn't merged yet? I'd like to use the gem for Rails 7 project but the dependency boundaries are falling for me. Maybe we should split the PR to two separate thing: one for Github Actions migrations another for Rails 7 support (if that's the reason of not merging this). BTW, do we really need upper boundary on |
Hi, any update? @sds @varyonic @geoffharcourt , is anything blocking a merge and release? I have some things I need to test under 7.0. I was considering whether to try to replace this gem with something else wondering if it was maintained, but it looks like it is maintained, there's lots of committer activity here, great! And thank you for your work! Is there anything we can help with to get to merge and release? Re @djezzzl ,
I personally think that is appropriate, yeah. There is no guarantee something reaching into the inners of Rails like this will work with subsequent rails releases, it's appropriate to put the boundary on currently tested versions, not assume it will work with future versions. But that only works if releases are done! :) |
(I'd also encourage a 1.0 release with this!) |
this looks great. thank you for putting this together |
I'm considering making a fork so I can use this in a rails 7 project. Or, does anyone here know of any good still-maintained alternatives that work with Rails 7? |
Hey all, this looks great. @sds Anything we can do to help release the next version of this gem? |
Also:
You can take a look at the results of the CI here: https://github.com/tagliala/db-query-matchers/pull/1/checks
Someone with permissions should enable workflows on this PR