Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Rails 7.0 #42

Merged
merged 5 commits into from
Feb 23, 2022
Merged

Allow Rails 7.0 #42

merged 5 commits into from
Feb 23, 2022

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Dec 17, 2021

Also:

  • Moves to GitHub Actions
  • Updates badges
  • Test against Ruby head and Rails edge

You can take a look at the results of the CI here: https://github.com/tagliala/db-query-matchers/pull/1/checks

Someone with permissions should enable workflows on this PR

- Remove dependabot
- Remove travis
- Move to SVG versions
@tagliala tagliala force-pushed the chore/allow-latest-gem-versions branch from 0119518 to 11863e2 Compare December 17, 2021 13:30
@varyonic
Copy link

@sds ?

@djezzzl
Copy link

djezzzl commented Dec 26, 2021

Hello 👋

Is there any reasons why it isn't merged yet? I'd like to use the gem for Rails 7 project but the dependency boundaries are falling for me.

Maybe we should split the PR to two separate thing: one for Github Actions migrations another for Rails 7 support (if that's the reason of not merging this).

BTW, do we really need upper boundary on activerecord < 7.1?

@jrochkind jrochkind mentioned this pull request Jan 4, 2022
@jrochkind
Copy link
Contributor

jrochkind commented Jan 4, 2022

Hi, any update? @sds @varyonic @geoffharcourt , is anything blocking a merge and release?

I have some things I need to test under 7.0. I was considering whether to try to replace this gem with something else wondering if it was maintained, but it looks like it is maintained, there's lots of committer activity here, great! And thank you for your work!

Is there anything we can help with to get to merge and release?

Re @djezzzl ,

BTW, do we really need upper boundary on activerecord < 7.1?

I personally think that is appropriate, yeah. There is no guarantee something reaching into the inners of Rails like this will work with subsequent rails releases, it's appropriate to put the boundary on currently tested versions, not assume it will work with future versions. But that only works if releases are done! :)

@jrochkind
Copy link
Contributor

(I'd also encourage a 1.0 release with this!)

@kbrock
Copy link

kbrock commented Jan 6, 2022

this looks great. thank you for putting this together

@jrochkind
Copy link
Contributor

I'm considering making a fork so I can use this in a rails 7 project. Or, does anyone here know of any good still-maintained alternatives that work with Rails 7?

@kbrock
Copy link

kbrock commented Feb 15, 2022

Hey all, this looks great. @sds Anything we can do to help release the next version of this gem?

@sds sds merged commit 9e8ab86 into sds:master Feb 23, 2022
@sds sds mentioned this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants