Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Haml 6.3 #458

Closed
tagliala opened this issue Dec 11, 2023 · 3 comments · Fixed by #459
Closed

Allow Haml 6.3 #458

tagliala opened this issue Dec 11, 2023 · 3 comments · Fixed by #459

Comments

@tagliala
Copy link
Contributor

No description provided.

tagliala added a commit to tagliala/haml-lint that referenced this issue Dec 11, 2023
@robbl-as
Copy link

To me, the problem is, that we can update haml-lint or haml, but not execute haml-lint afterwards. it Isn't there a solution to use gemfile dependencies to communicate compatibility? Is there a reason, why this is not done, yet? The advantage would be that versions would always be compatible with each other, right?

@tagliala
Copy link
Contributor Author

Here it is the reason why at the moment Haml is updatable but Haml lint isn't

#447 (comment)

(TL;DR: haml-lint should not prevent the update of a production library. It is not ideal, but it is better to fail in this way)

tagliala added a commit to tagliala/haml-lint that referenced this issue Dec 11, 2023
@tagliala
Copy link
Contributor Author

Also, there are breaking changes and deprecation between minor version of Haml. In this case, we have this: https://github.com/haml/haml/blob/main/CHANGELOG.md#630

tagliala added a commit to tagliala/haml-lint that referenced this issue Dec 11, 2023
@sds sds closed this as completed in #459 Dec 13, 2023
sds pushed a commit that referenced this issue Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants