Haml hash attributes spacing linter #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| context 'default config (space)' do | ||
| it { should_not report_lint } | ||
| end |
There was a problem hiding this comment.
We like to separate our blocks with a single blank line, e.g.
...
context ... do
...
end
# <-- Blank line
context ... do
...
end
|
Hey @seanwalbran, thanks for contributing this linter to I've left some comments inline. Once those are addressed I'll be happy to merge. Thanks! |
|
Thanks for addressing that feedback, @seanwalbran! Merged in e6fb407. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a linter for checking for spaces inside hash attribute braces, analogous to the Style/SpaceInsideHashLiteralBraces cop for spaces inside ruby hash literal braces.