Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve abort command #49

Merged
merged 9 commits into from
May 29, 2024
Merged

Improve abort command #49

merged 9 commits into from
May 29, 2024

Conversation

albireox
Copy link
Member

@albireox albireox commented May 29, 2024

Improves the abort command. When an integration or readout is ongoing, the current task is stored in the delegate and cancelled if an abort happens. This should immediately cancel the command and any controller action. To perform a full abort, one should also run the reset command, which will reset the controller, including a reset timings.

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.6%. Comparing base (dc7c988) to head (f602d0c).

Additional details and impacted files
@@           Coverage Diff           @@
##            main     #49     +/-   ##
=======================================
+ Coverage   87.5%   87.6%   +0.1%     
=======================================
  Files         23      23             
  Lines       2173    2187     +14     
  Branches     544     545      +1     
=======================================
+ Hits        1900    1914     +14     
  Misses       176     176             
  Partials      97      97             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albireox albireox merged commit 0974e66 into main May 29, 2024
6 checks passed
@albireox albireox deleted the albireox/abort-exposures branch May 29, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant