Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guider refactor #5

Merged
merged 39 commits into from
Sep 2, 2023
Merged

Guider refactor #5

merged 39 commits into from
Sep 2, 2023

Conversation

albireox
Copy link
Member

@albireox albireox commented Sep 2, 2023

Major refactor of the guider code. The main differences are:

  • Extracted sources are always matched to Gaia DR3 regardless of whether the solution was obtained using astrometry.net or kd-tree. lmag zero points are calculated for each source.
  • Once acquisition is complete the WCS of the individual cameras is determined from the Gaia cross-match, and not by tranlating the reference WCS using the measured offset. This allows each new WCS to also reflect changes in PA.
  • Average zero points and PAs are output.
  • All the metadata is carried out in two dataclasess, CameraSolution and GuiderSolution.
  • The output data model has changed. Former proc- files are now named lvm.{telescope}.guider, and sources are saved as parquet tables. The latter allows to preserve the column types in the presence of missing data.

@albireox albireox merged commit c220cf6 into main Sep 2, 2023
3 checks passed
@albireox albireox deleted the albireox-refactor_guider branch September 2, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant