-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor some features #65
Conversation
Deploying with Cloudflare Pages
|
Codecov Report
@@ Coverage Diff @@
## main #65 +/- ##
========================================
+ Coverage 66.0% 89.2% +23.2%
========================================
Files 12 17 +5
Lines 960 661 -299
Branches 187 112 -75
========================================
- Hits 633 589 -44
+ Misses 266 45 -221
+ Partials 61 27 -34
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my spaghetti codes, and thanks for upgrading my code with excellent quality. I will learn more from the refracted code.
This PR is a relatively major refactor of some features in
lvmieb
while maintaining most of the actor commands and functionality.The main changes are:
IEBController
into several classes for motors, WAGO, pressure transducers, and depth probes. In the current code theIebController
handles everything but actually multiple instances are generated for each spectrograph, one for each type of device. I think this is not ideal since a lot of the methods are not valid for the current device (for example, ifIebController
has been instantiated for a pressure transducer all the WAGO methods would fail). In this version theIEBController
is a pretty simple collection of individual controllers.IEBController
.