Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify code by assumming both SQLA and Peewee #35

Merged
merged 1 commit into from
May 14, 2020
Merged

Simplify code by assumming both SQLA and Peewee #35

merged 1 commit into from
May 14, 2020

Conversation

albireox
Copy link
Member

@albireox albireox commented May 14, 2020 •
edited
Loading

Fixes #32.

@coveralls
Copy link

coveralls commented May 14, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 236

  • 0 of 170 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 0.0%
Changes Missing Coverage Covered Lines Changed/Added Lines %
python/sdssdb/init.py 0 2 0.0%
python/sdssdb/connection.py 0 168 0.0%
Files with Coverage Reduction New Missed Lines %
python/sdssdb/peewee/init.py 1 0%
python/sdssdb/sqlalchemy/init.py 1 0%
Totals Coverage Status
Change from base Build 235: 0.0%
Covered Lines: 0
Relevant Lines: 5023
💛 - Coveralls

@albireox albireox merged commit 7ae2f77 into master May 14, 2020
@albireox albireox deleted the remove-underscore-orm branch May 14, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decide whether to install both peewee and SQLA or none
2 participants
@albireox @coveralls