tycid needed in tycho2 model class #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a really small change. I just wanted to flag it with one of you in case I missed something or this was being fixed elsewhere. |
|
Has this caused a problem with a previous version? The latest sdssdb should include tycid, does it not work? |
|
I tried pulling the latest version if main and 0.4.8 but both give errors when I try to import peewee model classes because this line is missing. |
|
Ah, I see, it matters if you are importing catalogdb in a computer without sdss5db or if your version of tycho2 doesn't have that column. Can you go ahead and merge? |
albireox
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.