Robust predictor data structure #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdtaylor
force-pushed
the
robust_predictor_data_structure
branch
from
afc2273
to
562f68d
Compare
with most models the only predictor variable is temperature, so that was the sole argument besides observations. Newer models require things like lat/long, daylength, precip, etc. This replaces all prior temperature calls with "predictors", where temperature can be one of many aspects. Required predictors are defined in the model. See the M1 model for an example. Since most models still just use temperature, that default is defined in the base model with some methods to check for it. If a model requies something besides temperature it must be defined within the model. Added a new model, M1, which uses a new variable, daylength. Also updated the example data to include lat/long and daylength
sdtaylor
force-pushed
the
robust_predictor_data_structure
branch
from
562f68d
to
b6c125e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.