shuf(1) is not part of POSIX, neither is 'sort -R' #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Just tried that on OpenBSD and then realised that seq(1) is also not part of POSIX. Solution found on Stackexchange with awk(1) here. Do you mind implementing that too or should I create another PR? |
|
Nathanael <notifications@github.com> wrote:
Looks good. Just tried that on OpenBSD and then realised that seq(1) is also not part of POSIX.
If DATA_LENGTH is a number then you can
```
@@ -188,7 +188,8 @@ list_emails() {
# 5
#
# We can then put those results into the foor loop
- for index in $(seq 1 "$DATA_LENGTH"); do
+ index=1
+ while [ $index -le "${DATA_LENGTH}" ]; do
# Since arrays in JSON data start at 0, we must subtract
# the value of $index by 1 so that we dont miss one of the
# emails in the array
@@ -203,6 +204,7 @@ list_emails() {
# but that would not work in our case as the email subject could have multiple white spaces
# and 'column' would split the words that are seperated by white space, in different columns.
INBOX="$INBOX$ID ||$FROM ||$SUBJECT\n"
+ index=$(( index + 1 ))
done
# Show the emails cleanly
```
|
|
Looks good. Thanks! |
This had been removed here to allow running the tool when w3m is not installed; a better way would be to move the check until after options have been parsed and possibly an alternate browser has been requested. But that would be a different change set / PR, so putting this back here for now.
tmpmail
Outdated
| @@ -282,7 +284,7 @@ print_error() { | |||
|
|
|||
| main() { | |||
| # Iterate of the array of dependencies and check if the user has them installed | |||
| for dependency in jq curl; do | |||
| for dependency in jq w3m curl; do | |||
There was a problem hiding this comment.
Same question and extension to check for required tools dependent on cli options would apply for:
awk, sort, cut, tail
|
A new feature was added in #46 and it uses |
|
Siddharth Dushantha <notifications@github.com> wrote:
A new feature was added in #46 and it uses `seq`.
Would you like to update the code to not include it?
You should be able to use the same logic here.
That is, instead of
```
for i in $(seq start end); do
...
done
```
use
```
i=start
while [ $i -le end ]; do
...
i=$(( i + 1 ))
done
```
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address issue #44.