-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 27: Create truncnorm distribution #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csala
approved these changes
Apr 23, 2019
copulas/univariate/base.py
Outdated
if method_name is None: | ||
method = getattr(self, name) | ||
setattr(self, name, missing_method_scipy_wrapper(method)) | ||
method_names = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be a class level attribute, self.METHOD_NAMES
. It also should be a tuple (immutable)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, already changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR include the changes in order to add the truncnorm distribution from scipy:
Univariate.base.ScipyWrapper
, it allows to integrate any subclass ofscipy.rv_continous
by just providing the name of the class and a mapping of the name of its methods, it's based oncopulas.univariate.kde
that already wraps a distribution from scipy.scalarize
andvectorize
decorators to help accept scalar values to vectorial methods and vice-versa.copulas.univariate.TruncNorm
.Resolves #27, resolves #85, and resolves #90