Remove unnecessary OneHotEncoder when there are nan values
#725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
requested review from
frances-h and
pvk-developer
and removed request for
a team
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1805 1805
=========================================
Hits 1805 1805
☔ View full report in Codecov by Sentry. |
frances-h
reviewed
Oct 18, 2023
| # Run | ||
| ohe.fit(data, 'column_name') | ||
| # Create a temporary file and dump the transformer | ||
| tmp = tempfile.NamedTemporaryFile() |
There was a problem hiding this comment.
Can we use the pytest tmp_path fixutre instead?
frances-h
approved these changes
Oct 18, 2023
Comment on lines
436
to
440
| tmp = tmp_path / 'ohe.pkl' | ||
| with open(tmp, 'wb') as tmp: | ||
| pickle.dump(ohe, tmp) | ||
| with open(tmp.name, 'rb') as tmp: | ||
| ohe_loaded = pickle.load(tmp) |
There was a problem hiding this comment.
nitpick: can we use different var names for the filepath and the file?
pvk-developer
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #616.