Multi column transformers crash when assigned to single column #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontanez24
reviewed
Oct 27, 2023
There was a problem hiding this comment.
LGTM! I filed an issue for this problem #734 . Can you tag in the description?
R-Palazzo
changed the title
amontanez24
approved these changes
Oct 30, 2023
pvk-developer
approved these changes
Oct 31, 2023
| }, | ||
| 'transformers': { | ||
| 'A': DummyMultiColumnTransformerNumerical(), | ||
| ('B2'): DummyMultiColumnTransformerNumerical(), |
There was a problem hiding this comment.
This ('B2') is 'B2' , either add ('B2', ) or set(['B2']), unless you are intending to pass just a string, then we can remove the ( )
R-Palazzo
deleted the
change-logic-hypertransformer-multi-column-transformer
branch
R-Palazzo
added a commit
that referenced
this pull request
Oct 31, 2023
R-Palazzo
added a commit
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86ayjyjhn
Resolve #734
This PR is to make the multi-column transformers work with a single column.