Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _set_fitted_parameters method to NullTransformer #834

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

frances-h
Copy link
Contributor

CU-86b0pv6p7
Resolve #827

@sdv-team
Copy link
Contributor

sdv-team commented Jun 6, 2024

@frances-h frances-h marked this pull request as ready for review June 6, 2024 15:38
@frances-h frances-h requested a review from a team as a code owner June 6, 2024 15:38
@frances-h frances-h requested review from rwedge and R-Palazzo and removed request for a team June 6, 2024 15:38
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have just one naming question

rdt/transformers/null.py Outdated Show resolved Hide resolved
@frances-h frances-h requested a review from R-Palazzo June 7, 2024 13:53
@frances-h frances-h merged commit 7183033 into main Jun 7, 2024
47 checks passed
@frances-h frances-h deleted the issue-827-_set_fitted_parameters-NullTransformer branch June 7, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add _set_fitted_parameters method to NullTransformer
4 participants