Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to torch 2.0 #1365

Closed
npatki opened this issue Apr 6, 2023 · 1 comment · Fixed by #1438
Closed

Upgrade to torch 2.0 #1365

npatki opened this issue Apr 6, 2023 · 1 comment · Fixed by #1438
Assignees
@fealho
Labels
maintenance Tasks related to infrastructure & dependencies
Milestone
1.2.0

Comments

@npatki
Copy link
Contributor

npatki commented Apr 6, 2023

Pytorch 2.0 was released a few weeks ago and is included as the default for Google Colab notebooks now.

Ideal Result: If SDV works on torch 2.0 (or if we can make minor modifications for it to work), then we should consider uncapping the max version of torch

Alternatively, we can just increase the cap for now to include 2.0.
@npatki npatki added the maintenance Tasks related to infrastructure & dependencies label Apr 6, 2023
This was referenced Apr 10, 2023
Open
Closed
@HarrisonWilde
Copy link

Any update on this? Would be great as its the only dependency in our work still locked to sub 2.0 pytorch!

@fealho fealho mentioned this issue May 24, 2023
Merged
@amontanez24 amontanez24 added this to the 1.2.0 milestone Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fealho fealho

Labels
maintenance Tasks related to infrastructure & dependencies
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Update tests to run on torch==2.0.1 sdv-dev/SDV
4 participants
@npatki @amontanez24 @fealho @HarrisonWilde