Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change path to filepath #1353

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Change path to filepath #1353

merged 1 commit into from
Apr 4, 2023

Conversation

fealho
Copy link
Member

@fealho fealho commented Apr 1, 2023

Resolve #1352.

@fealho
Copy link
Member Author

fealho commented Apr 1, 2023

@npatki @amontanez24 Just want to confirm that all the parameters I changed are indeed intended.

@fealho fealho marked this pull request as ready for review April 1, 2023 17:00
@fealho fealho requested a review from a team as a code owner April 1, 2023 17:00
@fealho fealho requested review from frances-h, npatki and amontanez24 and removed request for a team and frances-h April 1, 2023 17:00
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2023 •
edited
Loading

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (f71856a) 96.08% compared to head (5f59361) 96.08%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1353   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          47       47           
  Lines        3680     3680           
=======================================
  Hits         3536     3536           
  Misses        144      144
Impacted Files Coverage Δ
sdv/metadata/visualization.py 13.33% <40.00%> (ø)
sdv/data_processing/data_processor.py 98.57% <100.00%> (ø)
sdv/lite/single_table.py 98.00% <100.00%> (ø)
sdv/multi_table/base.py 98.93% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

amontanez24
amontanez24 approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

npatki
npatki approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@npatki npatki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fealho fealho merged commit f78c7d0 into master Apr 4, 2023
@fealho fealho deleted the issue-1352-path-filepath branch April 4, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontanez24 amontanez24 amontanez24 approved these changes

@npatki npatki npatki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change path to filepath for load and save methods
4 participants
@fealho @codecov-commenter @npatki @amontanez24