Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimeWarning: invalid value encountered in cast. #1380

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

amontanez24
Copy link
Contributor

resolves #1369

@amontanez24 amontanez24 requested a review from a team as a code owner April 19, 2023 01:14
@amontanez24 amontanez24 requested review from fealho and frances-h and removed request for a team April 19, 2023 01:14
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.42 🎉

Comparison is base (dfe3bba) 96.09% compared to head (b755128) 96.51%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1380      +/-   ##
==========================================
+ Coverage   96.09%   96.51%   +0.42%     
==========================================
  Files          48       48              
  Lines        3712     3701      -11     
==========================================
+ Hits         3567     3572       +5     
+ Misses        145      129      -16     
Impacted Files Coverage Δ
sdv/constraints/tabular.py 99.23% <100.00%> (ø)
sdv/utils.py 100.00% <100.00%> (+30.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

tests/unit/test_utils.py Outdated Show resolved Hide resolved
@@ -15,44 +15,6 @@ def cast_to_iterable(value):
return [value]


def display_tables(tables, max_rows=10, datetime_fmt='%Y-%m-%d %H:%M:%S', row=True):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being deleted? Is just not used anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's not used anywhere

@amontanez24 amontanez24 force-pushed the issue-1369-invalid-value-cast branch from 42d7695 to b755128 Compare April 19, 2023 17:06
Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@amontanez24 amontanez24 force-pushed the issue-1369-invalid-value-cast branch from b755128 to 3a3384c Compare April 20, 2023 22:43
@amontanez24 amontanez24 merged commit 23125a0 into master Apr 21, 2023
@amontanez24 amontanez24 deleted the issue-1369-invalid-value-cast branch April 21, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeWarning: invalid value encountered in cast.
4 participants