Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect all addons from top level __init__ #1453

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Conversation

frances-h
Copy link
Contributor

Improve add-on detection to automatically detect and add all addons from the top level __init__.py

@frances-h frances-h requested a review from a team as a code owner June 1, 2023 18:53
@frances-h frances-h requested review from pvk-developer and amontanez24 and removed request for a team June 1, 2023 18:53
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14 🎉

Comparison is base (e2ce243) 96.04% compared to head (8365bae) 96.18%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1453      +/-   ##
==========================================
+ Coverage   96.04%   96.18%   +0.14%     
==========================================
  Files          50       49       -1     
  Lines        3967     3982      +15     
==========================================
+ Hits         3810     3830      +20     
+ Misses        157      152       -5     
Impacted Files Coverage Δ
sdv/constraints/__init__.py 100.00% <ø> (ø)
sdv/multi_table/__init__.py 100.00% <ø> (ø)
sdv/single_table/__init__.py 100.00% <ø> (ø)
sdv/__init__.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

sdv/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just suggested some changes, other than that looks good! I have already tested it and it worked fine 🦖

Makefile Outdated Show resolved Hide resolved
sdv/__init__.py Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frances-h frances-h merged commit 68944fb into master Jun 6, 2023
@frances-h frances-h deleted the addon-detection branch June 6, 2023 13:34
@amontanez24 amontanez24 added this to the 1.2.0 milestone Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants