Fix _get_likelihoods not generating likelihood values #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1720 +/- ##
==========================================
+ Coverage 97.08% 97.13% +0.04%
==========================================
Files 48 48
Lines 4499 4507 +8
==========================================
+ Hits 4368 4378 +10
+ Misses 131 129 -2 ☔ View full report in Codecov by Sentry. |
amontanez24
reviewed
Dec 15, 2023
amontanez24
reviewed
Dec 18, 2023
Comment on lines
+513
to
+520
| transformed = data_processor.transform(table_rows) | ||
| if transformed.index.name: | ||
| table_rows = table_rows.set_index(transformed.index.name) | ||
|
|
||
| table_rows = pd.concat( | ||
| [transformed, table_rows.drop(columns=transformed.columns)], | ||
| axis=1 | ||
| ) |
There was a problem hiding this comment.
We have to transform the child row while keeping any extra columns in order for _get_likelihoods to work properly.
pvk-developer
approved these changes
Jan 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sampling after calling
reset_samplingwas different because bothfitandsamplehave to calltransforminHMA. Resetting sampling in the data processor after fitting re-aligns the randomness for sampling.