Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the dummy context column to metadata and not to extra_context_column #2019

Merged
merged 3 commits into from
May 21, 2024

Conversation

lajohn4747
Copy link
Contributor

resolves #1972
CU-86b08wr44

When sequence index is missing, par.py adds a constant column to allow for modeling as seen here. The added context column does not exist in the data though causing KeyErrors.

We only need the dummy column for context so only add it to metadata and not to extra_context_column which has downstream effects.

@lajohn4747 lajohn4747 requested a review from a team as a code owner May 20, 2024 22:57
@sdv-team
Copy link
Contributor

@lajohn4747 lajohn4747 added this to the 1.13.2 milestone May 21, 2024
@lajohn4747 lajohn4747 merged commit b8313c7 into main May 21, 2024
39 checks passed
@lajohn4747 lajohn4747 deleted the issue_1972_missing_sequence_index branch May 21, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PARSynthesizer model won't fit if sequence_index is missing
4 participants