Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sdv.timeseries model family #206

Merged
merged 17 commits into from
Oct 16, 2020
Merged

Add sdv.timeseries model family #206

merged 17 commits into from
Oct 16, 2020

Conversation

csala
Copy link
Contributor

@csala csala commented Oct 16, 2020

This PR introduces a new sdv.timeseries subpackage that includes a BaseTimeseriesModel class to be used for future timeseries models and a first PAR model that implements a Probabilistic AutoRegressive model.

As a side effect, it also adds support for composite primary keys in tabular datasets.

Resolve #142
Resolve #204
Resolve #207
Resolve #208

@codecov-io
Copy link

codecov-io commented Oct 16, 2020

Codecov Report

Merging #206 into master will decrease coverage by 7.26%.
The diff coverage is 12.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   83.00%   75.74%   -7.27%     
==========================================
  Files          24       27       +3     
  Lines        1648     1847     +199     
==========================================
+ Hits         1368     1399      +31     
- Misses        280      448     +168     
Impacted Files Coverage Δ
sdv/timeseries/__init__.py 0.00% <0.00%> (ø)
sdv/timeseries/base.py 0.00% <0.00%> (ø)
sdv/timeseries/deepecho.py 0.00% <0.00%> (ø)
sdv/demo.py 71.23% <33.33%> (-1.63%) ⬇️
sdv/metadata/table.py 85.82% <62.50%> (-3.41%) ⬇️
sdv/constraints/base.py 91.66% <0.00%> (+1.19%) ⬆️
sdv/tabular/base.py 85.93% <0.00%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5405fb...a2dc482. Read the comment docs.

@csala csala merged commit adf7ddc into master Oct 16, 2020
@csala csala deleted the timeseries branch October 16, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants