Support null foreign keys in get_random_subset #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsheni
reviewed
Jun 20, 2024
| 'The data contains null values in foreign key columns. ' | ||
| 'We recommend using ``drop_unknown_foreign_keys`` method from sdv.utils' | ||
| ' to drop these rows before using ``get_random_subset``.' | ||
| ) | ||
|
|
||
| try: | ||
| _subsample_disconnected_roots(result, metadata, main_table_name, ratio_to_keep) | ||
| _subsample_table_and_descendants(result, metadata, main_table_name, num_rows) | ||
| _subsample_ancestors(result, metadata, main_table_name, primary_keys_referenced) |
There was a problem hiding this comment.
Rather than removing the the code, should be make it controllable via a parameter on _subsample_data?
There was a problem hiding this comment.
Alright, done in a4f8295
rwedge
approved these changes
Jun 20, 2024
gsheni
approved these changes
Jun 21, 2024
rwedge
pushed a commit
that referenced
this pull request
Jul 12, 2024
rwedge
pushed a commit
that referenced
this pull request
Aug 16, 2024
rwedge
pushed a commit
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86b0vyyrv
Resolve #2056