Allow GreaterThan constraint to work with timestamp #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katxiao
requested review from
a team,
sarahmish and
csala
and removed request for
a team and
sarahmish
csala
approved these changes
Sep 22, 2021
| @@ -320,10 +320,14 @@ def _validate_inputs(cls, low, high, scalar, drop): | |||
| cls._validate_drop(scalar, drop) | |||
| high = cls._validate_scalar(scalar_column=low, column_names=high, scalar=scalar) | |||
| constraint_columns = tuple(high) | |||
| if isinstance(low, pd.Timestamp): | |||
| low = low.to_datetime64() | |||
There was a problem hiding this comment.
Minor detail, can we add a blank line below this one?
| elif scalar == 'high': | ||
| cls._validate_drop(scalar, drop) | ||
| low = cls._validate_scalar(scalar_column=high, column_names=low, scalar=scalar) | ||
| constraint_columns = tuple(low) | ||
| if isinstance(high, pd.Timestamp): | ||
| high = high.to_datetime64() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the GreaterThan constraint crashes when passed a pd.Timestamp value. Convert the timestamp to a datetime so that it is able to be compared.
Resolves #596