Add default output file behavior #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katxiao
requested review from
pvk-developer and
fealho
and removed request for
a team
katxiao
force-pushed
the
issue-693-default-output-file
branch
from
f67b6a0
to
f2fd393
Compare
Codecov Report
@@ Coverage Diff @@
## v0.14.0.dev #719 +/- ##
===============================================
- Coverage 66.00% 65.95% -0.05%
===============================================
Files 36 36
Lines 2665 2685 +20
===============================================
+ Hits 1759 1771 +12
- Misses 906 914 +8
Continue to review full report at Codecov.
|
fealho
approved these changes
Mar 3, 2022
katxiao
force-pushed
the
issue-693-default-output-file
branch
from
f1aac96
to
83a11f9
Compare
katxiao
added a commit
that referenced
this pull request
Mar 4, 2022
* Add default output file behavior * Add unit tests * cr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the default output file behavior specified in #693
Write sampling to a file by default. This file is deleted upon sampling completion. Otherwise, the file remains and an error message is shown to the user.
Resolves #693