* fixes #92 converted Table to a namedtuple #94
Conversation
|
|
ManuelAlvarezC
added
the
internal
sdv/data_navigator.py
Outdated
| @@ -147,7 +143,8 @@ def _anonymize_data(self): | |||
|
|
|||
| pii_fields = self.ht._get_pii_fields(ht_meta) | |||
| if pii_fields: | |||
| table.data = ht_table | |||
| # Table is a namedtuple, which is immutable, so instantiate a new one with transformed data | |||
There was a problem hiding this comment.
This line is too long and makes the TravisCI build crash, but a part from this, all your changes seems good to merge, could you please shorten it?
There was a problem hiding this comment.
Also a tip: If you want to check for linting issues on your local environment before open the PR, you can do it with make lint, or run the same build that TravisCI does with make test-all. In case you want further reference, please find our Contributing Guide here
There was a problem hiding this comment.
Thanks for the heads up - I found the contributing guide after I had used travis to debug. 😄
|
Hi @Aylr and thanks for your contribution! I'll proceed to merge the PR after this message, but before that I wanted to ask you for a little favor: Next time you collaborate with this project, would you mind commenting in the original issue before starting implementing it? This way we can assign it to you and avoid the unpleasant chance that when your changes are ready, somebody else has taken it. Thanks in advance for your comprehension :) |
|
Will do! |
|
Hi @Aylr Sorry to bother you once again, but would you mind sharing your name and email to be included in the Contributors of the project? |
No description provided.