Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default metrics #958

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Update default metrics #958

merged 3 commits into from
Aug 16, 2022

Conversation

fealho
Copy link
Member

@fealho fealho commented Aug 16, 2022

Resolve #949.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #958 (e7d0ac7) into master (65c8b53) will increase coverage by 1.53%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #958      +/-   ##
==========================================
+ Coverage   68.51%   70.04%   +1.53%     
==========================================
  Files          38       38              
  Lines        2849     2851       +2     
==========================================
+ Hits         1952     1997      +45     
+ Misses        897      854      -43     
Impacted Files Coverage Δ
sdv/metadata/table.py 81.79% <ø> (+0.25%) ⬆️
sdv/evaluation.py 68.96% <100.00%> (+58.05%) ⬆️
sdv/metadata/dataset.py 64.90% <0.00%> (+3.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fealho fealho marked this pull request as ready for review August 16, 2022 17:39
@fealho fealho requested a review from a team as a code owner August 16, 2022 17:39
@fealho fealho requested review from amontanez24 and removed request for a team August 16, 2022 17:39
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but besides that I think this looks good!

sdv/evaluation.py Show resolved Hide resolved
@fealho fealho merged commit 1cf7cb6 into master Aug 16, 2022
@fealho fealho deleted the issue-956-updated-metrics branch August 16, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default metrics for evaluate
3 participants