LO-IdeSetup: fix link to download code #103
Labels
Comments
yamgent
added a commit
that referenced
this issue
Aug 19, 2018
Before fb74fba, learning outcomes were written in README.adoc. Developers were instructed to use the 'Clone or download' button **above** the page, when viewing README.adoc on GitHub. This instruction no longer make sense after learning outcomes have a .adoc page on its own. Furthermore, the 'Clone or download' button will not be available on the rendered static website version anyway, even if it stayed in README.adoc. Let's fix the instruction's link to download code, by using the `site-githuburl` attribute declared in `build.gradle`. That attribute will not be declared when viewing the .adoc page on GitHub, so declare a separate attribute for `env-github` environment.
nelvintan
added a commit
to nelvintan/addressbook-level1
that referenced
this issue
Aug 22, 2018
[se-edu#103] LearningOutcomes.adoc: fix link to download code (se-edu#104)
mingliang94
pushed a commit
to mingliang94/addressbook-level1
that referenced
this issue
Aug 23, 2018
…se-edu#104)" This reverts commit ca2ab8c.
perrythewang
pushed a commit
to perrythewang/addressbook-level1
that referenced
this issue
Aug 23, 2018
Revert "[se-edu#103] LearningOutcomes.adoc: fix link to download code (se-edu#104)"
Zenious
pushed a commit
to Zenious/addressbook-level1
that referenced
this issue
Aug 27, 2018
…#104) Before fb74fba, learning outcomes were written in README.adoc. Developers were instructed to use the 'Clone or download' button **above** the page, when viewing README.adoc on GitHub. This instruction no longer make sense after learning outcomes have a .adoc page on its own. Furthermore, the 'Clone or download' button will not be available on the rendered static website version anyway, even if it stayed in README.adoc. Let's fix the instruction's link to download code, by using the `site-githuburl` attribute declared in `build.gradle`. That attribute will not be declared when viewing the .adoc page on GitHub, so declare a separate attribute for `env-github` environment.
NichPang1
added a commit
to NichPang1/addressbook-level1
that referenced
this issue
Aug 30, 2018
…se-edu#104)" This reverts commit ca2ab8c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Location: https://github.com/se-edu/addressbook-level1/blob/master/docs/LearningOutcomes.adoc#exercise-setup-project-in-intellij
Problem: it says 'link above' but the link actually appears in a different page.
Suggested: change to 'link in the project homepage' and give the correct link.
The text was updated successfully, but these errors were encountered: