Replace orderedset with ordered_set #106
Conversation
The orderedset PyPi package no longer works with Python 3.10, and has not been updated for years. Replace it with the functionally equivalent (but maintained) ordered-set package. Signed-off-by: Peter Chubb <peter.chubb@unsw.edu.au>
|
When/if this gets merged camkes-deps package on PyPi will have to be updated. |
|
I expect builds will fail as the docker images won't use the new CAmkES dependency. |
Bump the version so pip upgrade will find the new ordered-set dependency. Signed-off-by: Peter Chubb <peter.chubb@unsw.edu.au>
|
No problems from my side. Are there other repos who use the old dependency that we should also update? |
To answer my own question: according to github search the only other mentions are in |
|
This seems the minimum fix, looks ok to me. Since Python 3.6 he core functionality |
|
Background about the Python 3.10 bug: simonpercivall/orderedset#34 and simonpercivall/orderedset#36, switching to ordered-set is also recommended there. |
The method for uploading packages to PyPI has changed; document the current method in setup.py, plus add the now desirable description field, and an organisation-independent email address. Signed-off-by: Peter Chubb <peter.chubb@unsw.edu.au>
| @@ -39,9 +45,17 @@ | |||
| name='camkes-deps', | |||
| version='0.7.2', | |||
There was a problem hiding this comment.
This version should get a minor bump, otherwise any python installation that's already installed it won't update to the version with ordered-set without --force-reinstall
There was a problem hiding this comment.
Yes, that would have been better. #107 does bump it, I think that'll be fine overall.
There was a problem hiding this comment.
The version on PiPY was 0.7.1 so I figured 0.7.2 would be OK.
There was a problem hiding this comment.
That makes sense, pypi won't let you overwrite old versions (at least not easily, afaik). Looks like Siwei only updated the repo, but not pypi when he bumped that version. I think the public state is fine, although maybe the repo history is not fully consistent with when 0.7.2 actually was published, but I don't think that's a problem.
There was a problem hiding this comment.
Version 0.7.2 with these changes is on PyPI now, (with the exception of the whitespace changes Gerwin pushed)
There was a problem hiding this comment.
Odd, I did a camkes-deps pip install after this PR was merged and 0.7.2 was already installed for me without ordered-set. --force-reinstall was required to get ordered-set. I agree that bumping to 7.3 in #107 is fine overally
The orderedset PyPi package no longer works with Python 3.10,
and has not been updated for years.
Replace it with the functionally equivalent (but maintained) ordered-set
package.
Signed-off-by: Peter Chubb peter.chubb@unsw.edu.au