Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site build is broken #163

Closed
lsf37 opened this issue Nov 22, 2022 · 5 comments · Fixed by #164
Closed

site build is broken #163

lsf37 opened this issue Nov 22, 2022 · 5 comments · Fixed by #164
Assignees
Labels
bug Something isn't working

Comments

@lsf37
Copy link
Member

lsf37 commented Nov 22, 2022

Potentially an unexpectedly recent jekyll version or similar.

See: https://github.com/seL4/docs/actions/runs/3520086041/jobs/5900677174

Liquid Exception: no implicit conversion of Hash into Integer in /home/runner/work/docs/docs/content_collections/_dependencies/l4v.md
                    ------------------------------------------------
      Jekyll 4.0.1   Please append `--trace` to the `build` command 
                     for any additional information or backtrace. 
                    ------------------------------------------------
@lsf37 lsf37 added the bug Something isn't working label Nov 22, 2022
@kent-mcleod
Copy link
Member

Back further in the log there's a message about the SPDX-License-Identifier which wasn't in the previous log:

JEKYLL_ENV=production bundle exec jekyll build
Your /home/runner/work/docs/docs/.bundle/config config includes `# SPDX-License-Identifier`, which contains the dash character (`-`).
This is deprecated, because configuration through `ENV` should be possible, but `ENV` keys cannot include dashes.
Please edit /home/runner/work/docs/docs/.bundle/config and replace any dashes in configuration keys with a triple underscore (`___`).
Configuration file: /home/runner/work/docs/docs/_config.yml
      Remote Theme: Using theme matrixfox/jekyll-theme-bootstrap
            Source: /home/runner/work/docs/docs
       Destination: /home/runner/work/docs/docs/_site
 Incremental build: disabled. Enable with --incremental
      Generating... 
      Remote Theme: Using theme matrixfox/jekyll-theme-bootstrap
  Liquid Exception: no implicit conversion of Hash into Integer in /home/runner/work/docs/docs/content_collections/_dependencies/l4v.md
                    ------------------------------------------------
      Jekyll 4.0.1   Please append `--trace` to the `build` command 
                     for any additional information or backtrace. 
                    ------------------------------------------------

@kent-mcleod
Copy link
Member

This likely changed because the version of bundler changed:
Successfully installed bundler-2.3.26
Successfully installed bundler-2.3.25

@kent-mcleod
Copy link
Member

Oh, the runner image also changed from Image: ubuntu-20.04 to Image: ubuntu-22.04

@kent-mcleod
Copy link
Member

So we should probably pin the image to 20.04 until the site is updated to use the newer versions of Ruby.

@lsf37
Copy link
Member Author

lsf37 commented Nov 22, 2022

Oh, the runner image also changed from Image: ubuntu-20.04 to Image: ubuntu-22.04

Right, that explains a lot. Thanks for catching that. I'll pin the runner.

lsf37 added a commit that referenced this issue Nov 22, 2022
GitHub is currently transitioning `ubuntu-latest` to 22.04, which comes
with more recent default versions of ruby and bundler which fail the
docsite build. To prevent this, we force pin old OS version for now.

Fixes #163

Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
@lsf37 lsf37 linked a pull request Nov 22, 2022 that will close this issue
@lsf37 lsf37 self-assigned this Nov 22, 2022
lsf37 added a commit that referenced this issue Nov 22, 2022
GitHub is currently transitioning `ubuntu-latest` to 22.04, which comes
with more recent default versions of ruby and bundler which fail the
docsite build. To prevent this, we force pin old OS version for now.

Fixes #163

Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants