-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containerize the non-ros testing pipeline #161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eholum
commented
Feb 7, 2024
eholum
commented
Feb 7, 2024
sea-bass
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Went through my local workflows and everything is allll riiiiggghhhttt.
Thanks for doing all this @eholum!
Thanks for the nits! What even is ros? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will allow us to take advantage of docker's cache for pddl builds in the base python tests, finishing off the @ibrahiminfinite's request from #85.
I added another stage to the Dockerfile for a very, very basic non-ros build. This should keep the docker build cache until you blow up the dependencies (note this can happen when apt or pip packages get updated... so it's not bulletproof). The tests are now run in the built container.
Renamed the ROS images accordingly.
Build times for a cached build:
I fully recognize that I have a problem...