Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/ignore clrf after last multipart boundary #1

Closed
wants to merge 54 commits into from

Conversation

seakayone
Copy link
Owner

khajavi and others added 30 commits April 18, 2024 19:17
* update path codec.

* rendering path codecs.

* attaching docs.

* attaching examples.

* decoding and formatting path codecs.

* endpoint overview.

* endpoint with error example.

* describing input and outputs.

* describing errors.

* transform methods.

* openapi documentation.

* sfix.

* description of a book.

* description annotation.

* sfix.

* remove extra layers.

* generate endpoint from openapi.

* fix basePath for code generator.

* generating cli app from endpoints.

* update example path.

* fmt.
* Use `fork` in NettyRuntime

* Add comment to explain why to fork
…#2650) (zio#2714)

* Explicit and customizable error messages for Endpoint BadRequest (zio#2650)

* Update zio-http/shared/src/main/scala/zio/http/codec/BinaryCodecWithSchema.scala

Co-authored-by: John A. De Goes <john@degoes.net>

* Review changes

* Integrate changes from main

---------

Co-authored-by: John A. De Goes <john@degoes.net>
* implemented mutual ssl

* review comments, refactor config

* formatting
* initial cleanup.

* core concepts with example.

* add more contents.

* rename the page.

* fix mdoc error.
showcase for both client and server.
* testing http applications.

* zio test section.
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* add to sidebar.

* binary codecs for request and response bodies.

* trivial fix.

* revert faq.

* fmt.

* trivial code change.

* use :+ instead of appended
* move dsl to reference.

* remove unrelated index page.

* introduce reference section.

* better title.

* revert bad commits.

* revert more!

* update sidebar.

* update links.
* Remove Routes from HttpApp

* Remove Routes from internal API and examples

* Remove HttpApp from internal API and examples
* Avoid providing the environment on every request

* Use an empty runtime for AppRef initialization
* Add info about home routes

It took me a lot of time to find out how to express a route to the root path, a lot of friction. Lets make sure this never happens again by making this part of the very first example.

Also: remove ZERO WIDTH NON-JOINER character.

* breaking: Make `Root` a PathCodec

... to improve the DSL for root routes.

Also: remove the 'watch mode' section from the docs as watch mode is not intended for starting users.

* Replace `Root` by `Path.root`, `Empty` by `Path.empty`

Remove `Empty`.

* Document migration

* Update documentation

* sbt fmt

* Merge 2798
* initial work.

* fix.

* update.

* another update

* fix title.

* fix broken link.

* add http4s and tapir.

* fix broken link.
* move overview section to reference section.

* move template to body section.

* organize sidebar.

* zio version.
* Add `context` method to request context

* Remove dead code
* restructed sidebarjs and create tutorials section

* added doc card

* sidebar >> overview

* fix faq link

* fix  sidebar.js

* Update docs/examples/index.md

change title

Co-authored-by: Milad Khajavi <khajavi@gmail.com>

* Update docs/reference/index.md

reference

Co-authored-by: Milad Khajavi <khajavi@gmail.com>

* mv handler under routing section

---------

Co-authored-by: Milad Khajavi <khajavi@gmail.com>
…io#2809)

* Add tests to check if the ZIO Runtime is propagated to req execution

* Empty commit

* Execute flaky form test sequentially

* empty
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* enable benchmark.

* remove extra label zio-http.

* use ubuntu-latest.

* remove extra steps temporary.

* Revert "remove extra label zio-http."

This reverts commit 2ff090e.

* test on personal repo.

* remove condition.

* remove extra labels.

* clone the project.

* workaround: git init.

* git tag.

* initial commit.

* config git user and email.

* do not freeze.

* do not freeze plain text

* remove extra stuffs.

* revert changes.

* update ci.

* run only on pull request.

* reduce the performance floor.

* fmt.

* remove trigger check on pull request events.

* decrease performance floor to 300k/s.
* integration with zio config.

* fix broken link.

* sidebar.

* make the docs compile-safe.

* fmt.

* fix line numbering.
* Prune the environment when wiring the server

* Use explicit type when pruning

* Provide fresh layers to suite
Co-authored-by: Nabil Abdel-Hafeez <7283535+987Nabil@users.noreply.github.com>
987Nabil and others added 20 commits May 13, 2024 12:36
* protobuf generator

* update ci

* fix HttpContentCodec

* remove dependencies
* added a failing test for a schema with fields that are scala keywords

* fixed the code to handle keywords, failing test passes now

* enabling cross version building with scala 3 and scalameta 2.13 + scalafmt

* replaced scalameta with hard coded list of keywords (scalameta didn't play well with cross version build) + fmt

* after scalameta failed for tests cross version as well, I refined the dependency (only depend on parsers), excluded collections compat, and it now seem to work. Also refactored the code to get rid of a compilation warning
Unsafely fulfill Client promises to avoid race conditions
* Update ZIO to 2.1.1

* Update Java to 17/21

* Fix zio cli version

* Remove deprecated call to java URL constructor

* Test with ZIO 2.0.x

* Bump ZIO back to 2.1.1

* Run Body.fromFile in blocking threadpool

* Run `FileBody#asArray` in blocking threadpool

* Close file in blocking threadpool

* Wrap file.length() in ZIO.blocking

* Run entire `fromFileZIO` in blocking threadpool

* Use blocking aspect on MultipartSpec

* Use blocking aspect on other suites

* fmt

* FormSpec blocking

---------

Co-authored-by: Nabil Abdel-Hafeez <7283535+987Nabil@users.noreply.github.com>
* Attempt fix to StreamingForm blocking

* Run stream in blocking threadpool

* Add FIXME comment

* Disable flaky test for now
* run ci only on pull requests.

* downgrade zio-cli.
…io#2846)

apply more config parameters in WebSocketClientProtocolConfig
Co-authored-by: Nabil Abdel-Hafeez <7283535+987Nabil@users.noreply.github.com>
* initial work.

* rename.

* add usage section.

* create a separate section for declarative endpoints.

* fmt.

---------

Co-authored-by: Nabil Abdel-Hafeez <7283535+987Nabil@users.noreply.github.com>
middleware diagrams.

Co-authored-by: Nabil Abdel-Hafeez <7283535+987Nabil@users.noreply.github.com>
* feat: add Routes#serve Method

* fix: correct serve method

* feat: move to class method

* fix: refactor for last features

---------

Co-authored-by: Nabil Abdel-Hafeez <7283535+987Nabil@users.noreply.github.com>
Co-authored-by: Milad Khajavi <khajavi@gmail.com>
Co-authored-by: Nabil Abdel-Hafeez <7283535+987Nabil@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Avoid unsafely running effects when handling websockets

* Fix websocket failure promise

* Run `queue.offer` synchronously

* Add comment regarding sync offering
* Update dependencies and fix deprecations

* Regenerate GHA yml

* Downgrade to 2.13.13

* Also downgrade scoverage version

* Revert "Also downgrade scoverage version"

This reverts commit 71e2085.

* Revert "Downgrade to 2.13.13"

This reverts commit 8ac9d40.
* Fix client proxy

* Use `ctx.fireUserEventTriggered` instead of `super.userEventTriggered`

* Fix compiling
* Fix connection pooled client timeouts

* Fix test and use replace
@github-actions github-actions bot added bug Something isn't working maintenance docs labels May 23, 2024
@seakayone seakayone force-pushed the fix/ignore-clrf-after-last-multipart-boundary branch from 742e13c to 0645065 Compare May 23, 2024 06:20
@seakayone seakayone closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.